Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CrowdControl Setup #1890

Merged
merged 10 commits into from Nov 6, 2022
Merged

Conversation

dcvz
Copy link
Contributor

@dcvz dcvz commented Nov 2, 2022

Cleans up the setup of CrowdControl:

  • Refactor threading (no thread per effect)
  • Use #define for effect names
  • Fix issue that didn't allow you to enable/disable CC in-game
  • Simplify CC API
  • Enable CC on LInux & conditional building for other platforms

  • Tested on official CrowdControl client 馃殌
  • Additional testing (enabling/disabling mid game) also tested 馃殌

# Conflicts:
#	soh/soh/Enhancements/crowd-control/CrowdControl.cpp
@dcvz dcvz merged commit e6e7a7b into HarbourMasters:develop Nov 6, 2022
@dcvz dcvz deleted the chore/refactor-cc branch November 6, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants