New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodule lus #1943
Merged
Merged
submodule lus #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove lus * add lus submodule * some progress, still not sure how to get ZAPDUtils to link to ZAPD correctly * remove submodule to use fork * forked submodule for now * submodule stuff * getting somewhere with soh build * Some small updates * update submodule and fix condition variable error * lus pulseaudio fix * Update CMakeLists.txt Co-authored-by: briaguya <briaguya@alice> Co-authored-by: David Chavez <david@dcvz.io>
dcvz
force-pushed
the
new-dev
branch
2 times, most recently
from
November 10, 2022 08:56
be014e7
to
08c7cb1
Compare
dcvz
force-pushed
the
new-dev
branch
4 times, most recently
from
November 10, 2022 14:54
3cad685
to
73bfbcb
Compare
Not sure if this was affecting anything but it definitely was adding a subdirectory that did not exist.
* Fixes typo in add_subdirectory for libultraship. Not sure if this was affecting anything but it definitely was adding a subdirectory that did not exist. * Fixes switch builds (dependent on changes from https://github.com/briaguya-ai/libultraship/pull/4)
dcvz
reviewed
Nov 13, 2022
@@ -240,7 +240,7 @@ void OTRExporter_DisplayList::Save(ZResource* res, const fs::path& outPath, Bina | |||
{ | |||
word0 = 0; | |||
word1 = 0; | |||
spdlog::error(StringHelper::Sprintf("dListDecl == nullptr! Addr = {:08X}", GETSEGOFFSET(data))); | |||
// spdlog::error(StringHelper::Sprintf("dListDecl == nullptr! Addr = {:08X}", GETSEGOFFSET(data))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix this correctly as we have the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't remember where the other proper fix is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.