Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: copy otrs in windows into target dir #2704

Merged

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Apr 13, 2023

This adjusts the otr copy script to also copy the otrs to the target dir (x64/Debug and x64/Release) for windows.
This leverages the $<TARGET_FILE_DIR:tgt> property to get the exact directory that the soh.exe file will be placed in, so the otrs are placed side by side with it.

This step will only happen for windows machines.

This makes it so within the ExtractAssets.vcxproj the build command will look like

<Command Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">setlocal

cd C:\source\Shipwright\OTRExporter

"C:\Program Files\CMake\bin\cmake.exe" -E rm -f oot.otr oot-mq.otr soh.otr

C:\Python311\python.exe C:/source/Shipwright/OTRExporter/extract_assets.py -z C:/source/Shipwright/x64/Debug/ZAPD.exe --non-interactive

"C:\Program Files\CMake\bin\cmake.exe" -DSYSTEM_NAME=Windows -DTARGET_DIR="C:/source/Shipwright/x64/Debug" -DSOURCE_DIR=C:/source/Shipwright -DBINARY_DIR=C:/source/Shipwright/build -P C:/source/Shipwright/copy-existing-otrs.cmake

</Command>

Build Artifacts

@briaguya-ai briaguya-ai merged commit e72eeb9 into HarbourMasters:develop Apr 14, 2023
8 checks passed
@Archez Archez deleted the copy-otrs-windows-target-dir branch April 14, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants