Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N64 PAL 1.1 Support #2773

Merged
merged 7 commits into from Jun 5, 2023
Merged

N64 PAL 1.1 Support #2773

merged 7 commits into from Jun 5, 2023

Conversation

NEstelami
Copy link
Contributor

@NEstelami NEstelami commented Apr 29, 2023 •
edited by github-actions bot

@briaguya-ai briaguya-ai added the do not merge Not ready or not valid changes label Apr 29, 2023
@NEstelami NEstelami changed the title [WIP DO NOT MERGE] N64 PAL 1.1 Support N64 PAL 1.1 Support May 10, 2023
@NEstelami NEstelami removed the do not merge Not ready or not valid changes label May 10, 2023
Archez
Archez reviewed May 11, 2023
View reviewed changes
ZAPDTR/ZAPD/ZRom.cpp Outdated Show resolved Hide resolved
soh/src/overlays/actors/ovl_En_Mag/z_en_mag.c Outdated Show resolved Hide resolved
soh/src/overlays/actors/ovl_En_Mag/z_en_mag.c Outdated Show resolved Hide resolved
leggettc18
leggettc18 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@leggettc18 leggettc18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question made in a comment but it's only for me to get context and/or clarity so I've gone ahead and marked as approved.

soh/soh/Extractor/Extract.cpp Show resolved Hide resolved
leggettc18
leggettc18 requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@leggettc18 leggettc18 left a comment •
edited by NEstelami

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed these points, already brought them up in Discord but putting them here to be thorough.

  • Update the readme with the new rom hash
  • Update the appimage script with the new rom hash
  • Update the mac package script with the new rom hash

@leggettc18 leggettc18 merged commit 7e1ee6e into HarbourMasters:develop Jun 5, 2023
8 checks passed
@garrettjoecox garrettjoecox added this to the Sulu (7.1.x) milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez left review comments

@leggettc18 leggettc18 leggettc18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sulu (7.1.x)
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NEstelami @Archez @leggettc18 @garrettjoecox @briaguya-ai