update mac launch script to set SHIP_HOME #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
May 5, 2023
There was a problem hiding this comment.
this should be good for now. i know the people on nixOS are upset that we use SHIP_HOME as the binary, data, and config directory (goes against xdg specs #2285), but i'm happy to have cross-platform consistency here
Archez
changed the title
leggettc18
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the mac launch script to rename
DATA_SHAREtoSHIP_HOMEso the the env var can be read by LUS when trying to get the app dir path.Requires LUS PR: Kenix3/libultraship#192
Build Artifacts