Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TTS for file select menus #2950

Merged
merged 2 commits into from Jun 5, 2023

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Jun 5, 2023

There was some TTS on the file select menus, but not all of them, and now with boss rush in, the quest selection screen is always presented.

This PR adds TTS support for the missing areas:

  • Quest Selection
  • Name Entry
  • Boss Rush options

This PR also more carefully reads out the last button hovered when going forward/back between menus.

tts-file-select.mp4

Build Artifacts

Copy link
Contributor

@PurpleHato PurpleHato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny tiny tiny French spelling, else lgtm! :)

OTRExporter/assets/accessibility/texts/filechoose_fra.json Outdated Show resolved Hide resolved
@leggettc18 leggettc18 merged commit 820fdf7 into HarbourMasters:develop Jun 5, 2023
7 checks passed
@Archez Archez deleted the more-file-select-tts branch June 5, 2023 22:01
@garrettjoecox garrettjoecox added this to the Sulu (7.1.x) milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants