codeberg-forgejo/services/auth
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-29 13:50:09 +08:00
..
source Revert unrelated changes for SMTP auth (#21767) (#21768) 2022-11-10 16:11:56 -05:00
auth.go Remove dependent on session auth for api/v1 routers (#19321) 2022-04-08 06:22:10 +02:00
auth_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
basic.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
group.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
httpsign.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
interface.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
oauth2.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
reverseproxy.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
session.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
signin.go Restore user autoregistration with email addresses (#19261) 2022-03-31 15:20:25 +02:00
source.go Refactor auth package (#17962) 2022-01-02 21:12:35 +08:00
sspi_windows.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
sync.go Refactor auth package (#17962) 2022-01-02 21:12:35 +08:00