Commit Graph

23 Commits (pr/39792)

Author SHA1 Message Date
Shelley Vohr a8999bc529
fix: ensure `BrowserView` bounds are always relative to window (#39605)
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
Shelley Vohr 5a77c75753
revert: compensate for title bar height when setting bounds on `BrowserView` (#38981)
This reverts commit 75f9573e53.
2023-07-06 09:50:08 +02:00
Jeremy Rose 184ac2b382
refactor: move draggable regions to WebContents (#36230) 2022-11-07 10:15:57 -08:00
Daniel Kocielinski 23d4a252c6
chore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView (#35007)
* hore: Move draggable regions implementation from NativeBrowserView into InspectableWebContentsView

The draggable regions implementation is related to WebView, so
InspectableWebContentsView is a more appropriate place to put it there.
Also, this refactoring will allow the subsequent extension of the
WebContentsView API, which will eventually replace BrowserView API.

* fix: Lint error

* fix: Adjusted owner-window
2022-10-17 11:10:07 -04:00
Shelley Vohr 75f9573e53
fix: compensate for title bar height when setting bounds on `BrowserView` (#34713)
fix: compensate for title bar height when setting bounds
2022-08-29 17:53:03 +02:00
Aidan Nulman abf6f1cf78
fix: BrowserView drag now delegates to the OS when possible (#31114) 2021-09-28 21:12:22 +02:00
Shelley Vohr 919fd0f28d
fix: first mouse not dragging BrowserView (#31062) 2021-09-23 17:35:12 -04:00
David Sanders 81c5da5221
chore: use =default for default constructors/destructors (#29511) 2021-06-04 13:16:13 +09:00
Shelley Vohr e379b455c9
fix: drag region BrowserView calculations on macOS (#28984) 2021-05-05 11:37:59 -05:00
Shelley Vohr 79bcb882ac
fix: drag region offsets in BrowserViews (#28268) 2021-03-19 06:22:05 -07:00
Shelley Vohr 360d1b2bfd
fix: offset browserview drag regions on macOS (#27952) 2021-03-03 10:37:03 -08:00
Shelley Vohr fa09183ed1
fix: BrowserView rendering flicker (#27585) 2021-02-08 09:14:46 -08:00
Shelley Vohr 6307b52dc5
fix: default offset when no drag regions (#27147) 2021-01-04 14:01:32 -08:00
Shelley Vohr acfbbe9869
fix: draggable regions calculation in BrowserWindow/BrowserView (#26690) 2020-11-30 21:02:04 -08:00
Shelley Vohr d97612ed21
fix: webContents interaction with draggable browserviews (#26496) 2020-11-16 20:41:37 -08:00
Shelley Vohr e021639472
fix: draggable region edge calculation on resize (#26233)
* fix: draggable region edge calculation on resize

* Feedback from review
2020-10-29 12:51:56 -07:00
Shelley Vohr 7cdc42f43a
fix: draggable regions exclusively on BrowserViews (#26145) 2020-10-27 14:28:43 -07:00
Michaela Laurencin ea76788b67
refactor: remove native_browser_view web contents get function (#25526) 2020-09-21 10:39:58 -07:00
mlaurencin 53aaeb7a16
fix: prevent destroyed view references from causing crashes (#25411)
Closes #21666.

This PR is fixing crashes caused by referencing and attempting to modify previously destroyed views.
Before, when a view was destroyed and then the contents were referenced for modification, the system would crash as undefined memory was accessed. This fix explicitly makes the pointer to the destroyed view's contents null, so that this will not happen.
2020-09-16 18:10:49 -06:00
Micha Hanselmann 42a483ad27 feat: add getBounds() method for BrowserView (#19370)
* implement getBounds on mac

* add Linux/Win impl

* add test

* add docs
2019-07-29 19:43:05 -07:00
Samuel Attard 34c4c8d508 refactor: rename the atom namespace to electron 2019-06-19 17:33:28 -07:00
Samuel Attard 2160c1fcc9 refactor: replace includes for atom with shell 2019-06-19 17:33:28 -07:00
Samuel Attard d7f07e8a80 refactor: rename the atom directory to shell 2019-06-19 17:33:28 -07:00