4 Commits (pr/39792)

Author	SHA1	Message	Date
Samuel Attard	5d657dece4	build: enable JS semicolons (#22783)	2020-03-20 13:28:31 -07:00
Charles Kerr	c83f836faf	refactor: prefer using app.whenReady() (#21972) ... * docs: add references to app.whenReady() in isReady * refactor: prefer app.whenReady() In the docs, specs, and lib, replace instances of `app.once('ready')` (seen occasionally) and `app.on('ready')` (extremely common) with `app.whenReady()`. It's better to encourage users to use whenReady(): 1. it handles the edge case of registering for 'ready' after it's fired 2. it avoids the minor wart of leaving an active listener alive for an event that wll never fire again	2020-02-03 22:43:22 +00:00
Cheng Zhao	f9a1dc10fe	fix: quit after Chromium is fully started (#21488) ... * fix: quit when chromium is fully started * test: remove hacks on app.quit * chore: RunUntilIdle is unnecessary	2019-12-13 18:57:02 +09:00
Milan Burda	6f117b8e0c	feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() (#16282) ... * feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() * add more tests * refactor: move appendSwitch / appendArgument to command_line module * replace AppendSwitchASCII with AppendSwitchNative * remove castArgs	2019-01-07 07:48:27 -08:00