Shelley Vohr
6115b5f3b0
test: add tests for Storage Access API ( #41864 )
...
test: add tests for Storage Access API (#41698 )
2024-04-16 06:35:16 -04:00
Milan Burda
03bfd50875
feat: add support for configuring system network context proxies ( #41744 )
...
feat: add support for configuring system network context proxies (#41335 )
2024-04-03 13:09:44 -04:00
trop[bot]
484b75568f
fix: `Storage.{get|set|clear}Cookies` via CDP not working ( #41738 )
...
* fix: Storage.{get|set|clear}Cookies via CDP not working
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: simplify BrowserContext plumbing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-04-02 11:31:02 +02:00
trop[bot]
2e95cf50bb
docs: add missing headers option to ClientRequest options ( #41731 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2024-04-01 12:06:09 -04:00
John Kleinschmidt
c145388dd2
ci: use CircleCI hosted macOS arm64 runners for testing ( #41658 )
...
* ci: use CircleCI hosted macOS arm64 runners for testing
(cherry picked from commit 6ca2aa6b06
)
* ci: Use same version of xcode/macOS for both arm and x64 testing
2024-03-22 08:59:47 -04:00
trop[bot]
085363db07
fix: `chrome://process-internals` failing to load ( #41541 )
...
fix: chrome://process-internals failing to load
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-07 13:09:09 -05:00
trop[bot]
945f1c7262
fix: webContents.print options should be optional ( #41478 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-03-01 17:11:10 -05:00
Shelley Vohr
c96d7db592
fix: `node::loader::ImportModuleDynamically` crash ( #41491 )
...
* fix: node::loader::ImportModuleDynamically crash
* chore: add regression test
2024-03-01 15:51:51 -05:00
Shelley Vohr
abd7850ee4
fix: validate `printToPDF` `margins` against `pageSize` ( #41267 )
2024-02-08 11:15:42 +09:00
Shelley Vohr
b0c3534ecb
fix: webview zoom level persistence on navigation ( #41268 )
2024-02-08 11:15:19 +09:00
trop[bot]
e21a6bf385
fix: potential `async_hooks` crash in `NotifyWindowRestore` on Windows ( #41145 )
...
* fix: potential async_hooks crash in NotifyWindowRestore on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: don't use CallbackScope for Error objects
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-01-28 20:37:59 +01:00
trop[bot]
38b64d334f
fix: apply module search paths restriction on worker and child process ( #41137 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2024-01-26 14:20:44 -06:00
electron-roller[bot]
d60d4c6b2d
chore: bump chromium to 120.0.6099.225 (28-x-y) ( #40974 )
...
* chore: bump chromium in DEPS to 120.0.6099.217
* chore: bump chromium in DEPS to 120.0.6099.224
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 120.0.6099.226
* chore: fixup patches after rebase
* test: fixup assertNotWindows (#41045 )
* chore: fixup assertNotWindows
* remove logging
(cherry picked from commit 3dafb318a8
)
* chore: bump chromium in DEPS to 120.0.6099.225
* chore: cleanup global reject handler leaking into tests (#40689 )
(cherry picked from commit 3a510a26d0
)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Robo <hop2deep@gmail.com>
2024-01-22 16:39:25 -05:00
trop[bot]
cdf99a215a
chore: cleanup tests creating crashpad handler in the test runner process ( #41051 )
...
chore: cleanup tests creating crashpad handler in the test runner process (#40668 )
* chore: cleanup tests creating crashpad handler in the test runner process
* ci: logging
* ci: enable logging
* ci: more logging
* ci: run all tests
* ci: more logging
* ci: increase timeout
* Revert "ci: increase timeout"
This reverts commit 870f74455d
.
* Revert "ci: more logging"
This reverts commit 46837f8b3a
.
* Revert "ci: run all tests"
This reverts commit 6a7889ce67
.
* Revert "ci: more logging"
This reverts commit 351473ab43
.
* Revert "ci: enable logging"
This reverts commit 194109ed5a
.
* Revert "ci: logging"
This reverts commit 9a3396fc7a
.
* chore: disable flaky ia32 tests
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
2024-01-18 20:33:28 -05:00
trop[bot]
af42e8e9c7
fix: crash when `dialog.showMessageBoxSync` with missing buttons ( #41042 )
...
* fix: crash when dialog.showMessageBoxSync missing buttons
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-01-18 16:49:25 -05:00
trop[bot]
8f72f9bcb5
feat: add net module to utility process ( #40967 )
...
feat: add net module to utility process (#40017 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2024-01-18 09:56:32 -05:00
trop[bot]
efad0a8018
fix: InAppPurchase pre-emptive deallocation ( #40956 )
...
* fix: InAppPurchase pre-emptive deallocation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: try re-enabling IAP tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-01-11 13:14:22 -06:00
trop[bot]
0862529a86
build: use container runner for arm tests ( #40933 )
...
* build: use aks arm64 test runners
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: better image
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: even more stuff
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: arm par
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: use aks arm32
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: arm32 par
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: get test timings from abs paths
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* build: avoid realpath, use echo
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* chore: fix contentTracing test
* cry
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2024-01-10 23:11:40 +13:00
trop[bot]
73111dae51
fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable ( #40896 )
...
* fix: macOS maximize button shouldn't be disabled just because the window is non-fullscreenable
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
* add test
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
* fix test by enabling maximize button if `resizable && (maximizable || fullscreenable)` instead of `(resizable && maximizable) && fullscreenable`
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-01-08 21:55:34 +01:00
trop[bot]
7989f02a43
fix: ignore all NODE_ envs from foreign parent in node process ( #40880 )
2024-01-04 13:34:10 +01:00
trop[bot]
14c6651e35
feat: enable code cache for custom protocols ( #40709 )
...
* feat: enable code cache for custom protocols
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
* chore: update feat_allow_code_cache_in_custom_schemes.patch
* chore: e patches all
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2023-12-13 12:48:48 -06:00
trop[bot]
66e4c3089b
fix: prevent node mode to be used as script runner by other apps ( #40710 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2023-12-11 12:35:06 +09:00
trop[bot]
fe49f1c79a
fix: clean up devtools frontend_host on webcontents destroy ( #40679 )
...
* fix: clean up devtools frontend_host on destroy
Co-authored-by: Albert Xing <albertxing@slack-corp.com>
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
Co-authored-by: Albert Xing <albertxing@slack-corp.com>
* test: add a test for re-opening devtools
Co-authored-by: Albert Xing <albertxing@slack-corp.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Albert Xing <albertxing@slack-corp.com>
2023-12-03 18:25:34 +01:00
trop[bot]
5bc8e761d6
fix: add missing `set_wants_to_be_visible(true)` to `NativeWindowMac::ShowInactive()` ( #40659 )
...
* fix: add missing set_wants_to_be_visible(true) to NativeWindowMac::ShowInactive()
Co-authored-by: zaza <tamas@miro.com>
* add test
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zaza <tamas@miro.com>
Co-authored-by: Tamás Zahola <tzahola@gmail.com>
2023-12-03 17:36:57 +01:00
trop[bot]
f939be0638
feat: add/update missing Display properties ( #40554 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-11-27 13:47:31 -05:00
trop[bot]
131c5e7986
fix: maximized window bounds when toggle setResizable ( #40582 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Malinowski <tomasz@openfin.co>
2023-11-22 10:58:47 +01:00
trop[bot]
9a4b32d517
fix: emit will-navigate for links in chrome: pages ( #40525 )
...
* fix: emit will-navigate for links in chrome: pages
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* test: will-navigate emitted from chrome: pages
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
* Update shell/browser/electron_navigation_throttle.cc
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com>
2023-11-15 10:50:12 +01:00
trop[bot]
8eb6b35fc0
fix: `chrome.action` API registration ( #40514 )
...
* fix: chrome.action API registration
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: browser_action implemented_in
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-11-13 11:26:55 +01:00
trop[bot]
b92b4c8fcf
fix: Do not activate app when calling focus on inactive panel window ( #40465 )
...
* fix: Do not activate app when calling focus on inactive panel window
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* Use activate
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
* Use "activate" for all windows
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Felix Rieseberg <fr@makenotion.com>
2023-11-10 15:40:47 -05:00
Shelley Vohr
6916e19ce1
refactor: remove DevTools legacy UI patching ( #40409 )
...
* refactor: remove DevTools legacy UI patching
* chore: update patches
---------
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-01 16:24:06 -04:00
trop[bot]
45fbdcca6a
fix: `navigator.keyboard.lock()` fullscreen exit handling ( #40389 )
...
fix: navigator.keyboard.lock() fullscreen exit handling
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-10-31 21:23:50 -04:00
trop[bot]
d0d2a64739
refactor: options parsing in WebContents.prototype.printToPDF() ( #40279 )
...
* refactor: options parsing in WebContents.prototype.printToPDF()
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* tweak parsePageSize
Co-authored-by: Milan Burda <milan.burda@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2023-10-30 11:55:29 -07:00
trop[bot]
f6d7aba69c
test: add spec for `app.getAppMetrics()` for utility process ( #40312 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2023-10-25 09:30:28 -04:00
trop[bot]
22687c18c4
test: add spec for `child-process-gone` event for utility process ( #40304 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2023-10-23 11:44:22 -07:00
trop[bot]
3cf8652027
fix: correctly track receiver for methods called via ctx bridge ( #40263 )
...
* fix: correctly track receiver for methods called via ctx bridge
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* spec: test for correct contextBridge passage
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-10-18 21:24:16 +02:00
trop[bot]
9ddd08ba89
fix: support the throwIfNoEntry option to statSync and lstatSync in asar files ( #40224 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2023-10-18 11:33:48 +02:00
trop[bot]
a5f01f0328
docs: fix some string union typings ( #40199 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2023-10-16 14:10:13 +09:00
trop[bot]
f8d4c45f8e
fix: ensure MessagePorts get GCed when not referenced ( #40201 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-10-16 09:18:36 +09:00
trop[bot]
e3e7bf3786
fix: `webContents.capturePage()` for hidden windows on Windows/Linux ( #40185 )
...
fix: capturePage for hidden windows on Windows/Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-10-12 13:54:43 +02:00
Milan Burda
2c88626b51
chore: revert deprecate as an internal module ( #40146 )
...
Revert "chore: restore deprecate as an internal module (#40124 )"
This reverts commit 737e3de3fa
.
2023-10-10 11:50:47 -04:00
Shelley Vohr
7e312c81ca
test: make capturePage color matching timeouts consistent ( #40158 )
2023-10-10 11:13:07 -04:00
Shelley Vohr
86df4db6f1
fix: crash when calling non-reentrant function in `loadURL` ( #40143 )
2023-10-10 12:46:04 +02:00
Milan Burda
24bc0ee5c7
test: fix "crashed event does not crash main process when destroying WebContents in it" ( #40135 )
2023-10-09 09:56:48 +02:00
Milan Burda
737e3de3fa
chore: restore deprecate as an internal module ( #40124 )
...
* Revert "refactor: don't expose deprecate as an internal module (#35311 )"
This reverts commit 8424779906
.
* check crashed event warnings
2023-10-09 08:55:16 +09:00
David Sanders
8b8fbd0408
test: add back smoke test for removed API ( #40132 )
2023-10-09 08:46:56 +09:00
Shelley Vohr
3392d9a2e7
fix: all children showing when showing child window ( #40062 )
2023-10-05 09:19:57 -04:00
Shelley Vohr
713d8c4167
feat: add `tabbingIdentifier` property to `BrowserWindow` ( #39980 )
...
feat: add tabbingIdentifier property to BrowserWindow
2023-10-03 12:27:40 -07:00
Milan Burda
d301616f60
chore: remove deprecated `app.runningUnderRosettaTranslation()` ( #39956 )
2023-10-02 10:55:32 +02:00
Shelley Vohr
5643e86956
chore: update extensions url handling to match upstream ( #40038 )
...
- https://chromium-review.googlesource.com/c/chromium/src/+/4772028
- https://chromium-review.googlesource.com/c/chromium/src/+/4264656
- https://chromium-review.googlesource.com/c/chromium/src/+/4712150
2023-10-02 10:35:00 +02:00
Samuel Attard
371e83a8d2
fix: support esm entrypoint to utility process ( #40047 )
2023-09-29 14:38:37 -07:00