mirror of https://github.com/electron/electron
25 lines
1000 B
Diff
25 lines
1000 B
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Zac Walker <zac.walker@microsoft.com>
|
|
Date: Thu, 20 Sep 2018 17:49:55 -0700
|
|
Subject: ignore_rc_check.patch
|
|
|
|
Dont compare RC.exe and RC.py output.
|
|
FIXME: It has to be reverted once the script is fixed.
|
|
|
|
diff --git a/build/toolchain/win/rc/rc.py b/build/toolchain/win/rc/rc.py
|
|
index a650506a1e0a19566861b672cb800024965d7ff5..cde05b15eef3decdee0093ca8b84201008e4adb0 100755
|
|
--- a/build/toolchain/win/rc/rc.py
|
|
+++ b/build/toolchain/win/rc/rc.py
|
|
@@ -244,7 +244,10 @@ def CompareToMsRcOutput(preprocessed_output, is_utf8, flags):
|
|
# Assert Microsoft rc.exe and rc.py produced identical .res files.
|
|
if rc_exe_exit_code == 0:
|
|
import filecmp
|
|
- assert filecmp.cmp(msrc_out, flags.output)
|
|
+ # Temporarily ignore compares
|
|
+ # Nightly builds use very large version numbers that fail this check
|
|
+ # FIXME(zacwalk): Enable the assert.
|
|
+ # assert filecmp.cmp(msrc_out, flags.output)
|
|
return rc_exe_exit_code
|
|
|
|
|