mirror of https://github.com/electron/electron
23 lines
1023 B
Diff
23 lines
1023 B
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Samuel Attard <samuel.r.attard@gmail.com>
|
|
Date: Thu, 18 Oct 2018 17:07:47 -0700
|
|
Subject: dump_syms.patch
|
|
|
|
dylib currently fails to resolve Squirrel.framework on OSX, we need to fix
|
|
this but it is not a blocker for releasing Electron. This patch removes
|
|
tthe hard fail on dylib resolve failure from dump_syms
|
|
|
|
diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py
|
|
index 1e5ebd243c1f1eeb37d087a9d72afcfd947ec6a0..fe43b91f5c52e3f99dcec9cddb3cacfae1eb4646 100755
|
|
--- a/components/crash/content/tools/generate_breakpad_symbols.py
|
|
+++ b/components/crash/content/tools/generate_breakpad_symbols.py
|
|
@@ -204,7 +204,7 @@ def GetSharedLibraryDependenciesMac(binary, exe_path):
|
|
'rpaths %s' %
|
|
(m.group(1), exe_path, loader_path, ', '.join(rpaths))),
|
|
file=sys.stderr)
|
|
- sys.exit(1)
|
|
+ # sys.exit(1)
|
|
return deps
|
|
|
|
|