git/negotiator
Jeff King 1a60f2066a drop trailing newline from warning/error/die messages
Our error reporting routines append a trailing newline, and the strings
we pass to them should not include them (otherwise we get an extra blank
line after the message).

These cases were all found by looking at the results of:

  git grep -P '[^_](error|error_errno|warning|die|die_errno)\(.*\\n"[,)]' '*.c'

Note that we _do_ sometimes include a newline in the middle of such
messages, to create multiline output (hence our grep matching "," or ")"
after we see the newline, so we know we're at the end of the string).

It's possible that one or more of these cases could intentionally be
including a blank line at the end, but having looked at them all
manually, I think these are all just mistakes.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2024-09-05 09:07:12 -07:00
..
default.c refs: add referent to each_ref_fn 2024-08-09 08:47:34 -07:00
default.h fetch-pack: introduce negotiator API 2018-06-15 08:44:24 -07:00
noop.c treewide: remove unnecessary includes in source files 2023-12-26 12:04:31 -08:00
noop.h negotiator/noop: add noop fetch negotiator 2020-08-18 13:25:05 -07:00
skipping.c drop trailing newline from warning/error/die messages 2024-09-05 09:07:12 -07:00
skipping.h negotiator/skipping: skip commits during fetch 2018-07-16 14:51:12 -07:00