golang/src/cmd/compile/internal
Robert Griesemer cc95d85fe4 cmd/compile: remove quoting in favor of clearer prose in error messages
In an attempt to address issue #65790 (confusing error messages),
quoting of names was introduced for some (but not all) names used
in error messages.

That CL solved the issue at hand at the cost of extra punctuation
(the quotes) plus some inconsistency (not all names were quoted).

This CL removes the quoting again in favor or adding a qualifying noun
(such as "name", "label", "package", "built-in" etc.) before a user-
specified name where needed.

For instance, instead of

        invalid argument to `max'

we now say

        invalid argument to built-in max

There's still a chance for confusion. For instance, before an error
might have been

        `sadly' not exported by package X

and now it would be

        name sadly not exported by package X

but adverbs (such as "sadly") seem unlikely names in programs.

This change touches a lot of files but only affects error messages.

Fixes #67685.

Change-Id: I95435b388f92cade316e2844d59ecf6953b178bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/589118
Auto-Submit: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
2024-05-30 19:19:55 +00:00
..
abi cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
abt all: fix misuses of "a" vs "an" 2023-04-04 14:20:53 +00:00
amd64 cmd/compile: don't use BTS when OR works, add direct memory BTS operations 2023-08-04 16:40:24 +00:00
arm all: add floating point option for ARM targets 2023-11-20 17:19:36 +00:00
arm64 cmd/compile: intrinsify atomic And/Or on arm64 2024-05-23 15:49:20 +00:00
base cmd/compile: disable AlignHot on plan9/386 2024-05-21 11:57:40 +00:00
bitvec
compare cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
coverage cmd/compile/internal: refactor coverage ir.Name flags 2024-03-29 21:55:46 +00:00
devirtualize cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
dwarfgen cmd/compile: mark DIEs of captured variables 2024-03-06 15:23:18 +00:00
escape cmd/compile: fix escape analysis of string min/max 2023-12-05 22:06:07 +00:00
gc cmd/compile, cmd/internal: fine-grained fiddling with loop alignment 2024-05-15 15:44:14 +00:00
importer cmd/compile: stop using internal/godebug 2024-05-09 13:50:03 +00:00
inline cmd/compile: for rangefunc, add checks and tests, fix panic interactions 2024-05-21 21:08:03 +00:00
ir cmd/compile: repairing variable names and comments 2024-05-23 01:05:44 +00:00
liveness cmd/link: disallow pull-only linknames 2024-05-15 19:57:43 +00:00
logopt cmd/compile/internal/ir: add Func.DeclareParams 2023-09-14 13:15:50 +00:00
loong64 cmd/compile/internal: add spill support for loong64 regABI 2023-11-21 19:04:16 +00:00
loopvar all: remove newline characters after return statements 2023-12-14 17:22:18 +00:00
mips cmd/compile/internal/mips: use hardware NOP instruction as NOOP on mips platform 2023-08-01 14:53:45 +00:00
mips64 cmd/compile/internal/mips: use hardware NOP instruction as NOOP on mips platform 2023-08-01 14:53:45 +00:00
noder runtime: move exit hooks into internal/runtime/exithook 2024-05-23 02:32:19 +00:00
objw cmd/compile: move ssagen.dvarint to objw.Uvarint 2023-10-18 16:32:12 +00:00
pgoir cmd/compile: add debug log prior to export data lookup 2024-04-24 15:55:17 +00:00
pkginit cmd/compile: create "init" function during noding 2023-08-24 23:19:42 +00:00
ppc64 cmd/compile/internal/ssa: reintroduce ANDconst opcode on PPC64 2024-05-22 19:59:38 +00:00
rangefunc cmd/compile: repairing variable names and comments 2024-05-23 01:05:44 +00:00
reflectdata all: use kind* of abi 2024-04-02 15:10:48 +00:00
riscv64 cmd/compile,cmd/internal/obj: provide rotation pseudo-instructions for riscv64 2024-03-07 14:57:07 +00:00
rttype cmd/link: use symbolic offset for ITab.Type 2024-02-08 03:01:24 +00:00
s390x cmd/asm: refine some APIs related to Prog.RestArgs[] 2023-05-24 01:26:58 +00:00
ssa cmd/compile: intrinsify atomic And/Or on arm64 2024-05-23 15:49:20 +00:00
ssagen cmd/compile: intrinsify atomic And/Or on arm64 2024-05-23 15:49:20 +00:00
staticdata cmd/internal/objabi: rename R_USEGENERICIFACEMETHOD to R_USENAMEDMETHOD. 2023-09-01 15:08:50 +00:00
staticinit cmd/compile: add missing OASOP case in mayModifyPkgVar 2024-04-02 17:16:14 +00:00
syntax cmd/compile: remove quoting in favor of clearer prose in error messages 2024-05-30 19:19:55 +00:00
test cmd/compile/internal: stack slot merging region formation enhancements 2024-04-18 15:43:53 +00:00
typebits cmd/compile/internal/types: overhaul and simplify API 2023-08-22 01:53:41 +00:00
typecheck cmd/compile: for rangefunc, add checks and tests, fix panic interactions 2024-05-21 21:08:03 +00:00
types all: fix some comments 2024-04-04 14:29:45 +00:00
types2 cmd/compile: remove quoting in favor of clearer prose in error messages 2024-05-30 19:19:55 +00:00
walk cmd/compile: avoid past-the-end pointer when zeroing 2024-05-08 17:09:06 +00:00
wasm cmd/compile: batch write barrier calls 2023-02-24 00:21:13 +00:00
x86 cmd/asm: refine some APIs related to Prog.RestArgs[] 2023-05-24 01:26:58 +00:00