golang

History

Matthew Dempsky a509cae90d cmd/compile: record InlCost in export data Previously, we were treating cross-package function calls as free for inlining budgeting. In theory, we should be able to recompute InlCost from the exported/reimported function bodies. However, that process mutates the structure of the Node AST enough that it doesn't preserve InlCost. To avoid unexpected issues, just record and restore InlCost in the export data. Fixes #19261. Change-Id: Iac2bc0d32d4f948b64524aca657051f9fc96d92d Reviewed-on: https://go-review.googlesource.com/70151 Run-TryBot: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Robert Griesemer <gri@golang.org>	2017-10-11 23:20:44 +00:00
..
p.go	cmd/compile: record InlCost in export data	2017-10-11 23:20:44 +00:00
q.go	cmd/compile: record InlCost in export data	2017-10-11 23:20:44 +00:00

Matthew Dempsky a509cae90d cmd/compile: record InlCost in export data

Previously, we were treating cross-package function calls as free for
inlining budgeting.

In theory, we should be able to recompute InlCost from the
exported/reimported function bodies. However, that process mutates the
structure of the Node AST enough that it doesn't preserve InlCost. To
avoid unexpected issues, just record and restore InlCost in the export
data.

Fixes #19261.

Change-Id: Iac2bc0d32d4f948b64524aca657051f9fc96d92d
Reviewed-on: https://go-review.googlesource.com/70151
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Robert Griesemer <gri@golang.org>

2017-10-11 23:20:44 +00:00

p.go

cmd/compile: record InlCost in export data

2017-10-11 23:20:44 +00:00

q.go

cmd/compile: record InlCost in export data

2017-10-11 23:20:44 +00:00