mirror
/
golang
mirror of https://go.googlesource.com/go
1
0
Fork 0
Code Issues Releases Wiki Activity
golang/test/fixedbugs/issue49094.dir
History
Cuong Manh Le 9ff91b9098 cmd/compile: only look for struct type when crawling inline body 
CL 356254 fixed crawling of embeddable types during inline. However, we
are too agressive, since when we call markEmbed for every type seen
during inlining function body. That leads to false positive that for a
non-embedded type, its unexported methods are also marked inline.

Instead, we should only look at struct type that we seen during inlining
function body, and calling markEmbed for all of its embedded fields.

Fixes #49094

Change-Id: I6ef9a8bf1fc649ec6bf75e4883f6031ec8560ba1
Reviewed-on: https://go-review.googlesource.com/c/go/+/357232
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
 		2021-10-22 00:57:18 +00:00
..
a.go cmd/compile: only look for struct type when crawling inline body 2021-10-22 00:57:18 +00:00
b.go cmd/compile: only look for struct type when crawling inline body 2021-10-22 00:57:18 +00:00
p.go cmd/compile: only look for struct type when crawling inline body 2021-10-22 00:57:18 +00:00