Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update CONTRIBUTING.md, add pull request templates #1216

Merged
merged 5 commits into from Dec 9, 2022

Conversation

tsmethurst
Copy link
Contributor

Update contributing.md:

  • Add pull request processes. These just codify what we already did anyway.
  • Add guidelines for opening feature requests + bug reports.
  • Move stub CoC to its own separate document, where it can more easily be updated later.
  • Add a section to help new contributors find their way around the code.

Add pull request templates, which reference the updated contributing.md.

- Add Pull Request process and guidelines.
- Add feature/bug issue process.
- Rearrange some sections for clarity.
- Add overview of package structure.
These link to the new CONTRIBUTING.md document, and include a checklist to validate that contributors have read the guidelines.
@mal0ki
Copy link
Member

mal0ki commented Dec 6, 2022

I have a TON of comments for other things than the actual changes here, so I will try to handle that elsewhere.


In lieu of a fuller code of conduct, here are a few ground rules.

1. We *DO NOT ACCEPT* PRs from right-wingers, Nazis, transphobes, homophobes, racists, harassers, abusers, white-supremacists, misogynists, tech-bros of questionable ethics. If that's you, politely fuck off somewhere else.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth including ableists here? And some means of including "enlightened centrist" types of any kind, i.e. anyone who hates the "left" and "SJWs"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

  • absolutely no capitalism supporters
  • no cop supporters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both good ideas 👍 For now this PR is mostly about the contributing.md document. The CoC here is just copied from what we had previously as a stub, so I think we can work on it outside this PR

@tsmethurst tsmethurst merged commit 610c270 into main Dec 9, 2022
@tsmethurst tsmethurst deleted the update_contributing_md branch December 9, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants