Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Hide vendor from diffs #1729

Merged
merged 1 commit into from May 2, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented May 2, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

Linguist already classifies vendor/ as vendored files, meaning they don't count towards things like a repo language stat, but are still shows in diffs.

By classifying them as generated instead they're not only excluded from language stats but also hidden in diffs.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

Linguist already classifies vendor/ as vendored files, meaning they
don't count towards things like a repo language stat, but are still
shows in diffs.

By classifying them as generated instead they're not only excluded from
langauge stats but also hidden in diffs.
@daenney
Copy link
Member Author

daenney commented May 2, 2023

Linguist seems to already do this in a more limited fasion: https://github.com/github-linguist/linguist/blob/master/lib/linguist/generated.rb#L395-L397. Weird tld-check there too.

@NyaaaWhatsUpDoc
Copy link
Member

oh my god. so useful! you angel!

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit c41c1f9 into superseriousbusiness:main May 2, 2023
2 checks passed
@daenney daenney deleted the hide-vendor branch May 3, 2023 06:25
@daenney
Copy link
Member Author

daenney commented May 3, 2023

I kinda hope this works as expected. I have a mild suspicion that what they mean with "hidden in diff" is the file diff isn't loaded but still shows in the listing during reviews, which would be annoying. It's not super well documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants