[chore] tidy up media manager, add calling func to errors, build-script improvements #1835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
media.Manager
postData
callback function, instead uses a wrapped read closer when neededNew
andNewf
functions togtserror
that return an error prefixed with calling function namedereferencing
to use these new error typesNewFromResponse()
error function string building (and uses new above-mentioned errors)scripts/build.sh
to support passing in Go build configuration values via env, and logs the build commandChecklist
go fmt ./...
andgolangci-lint run
.