Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Allow lowercase emoji shortcode in frontend #1851

Merged
merged 5 commits into from Jun 2, 2023

Conversation

moan0s
Copy link
Contributor

@moan0s moan0s commented May 31, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request fixes #1833

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@moan0s
Copy link
Contributor Author

moan0s commented May 31, 2023

I did not add tests as I don't know enough about the project yet to do that :D I promise to learn that at some point

@moan0s moan0s marked this pull request as ready for review May 31, 2023 13:55
@tsmethurst
Copy link
Contributor

There's a test failing here: internal/api/client/admin/emojiupdate_test.go:476 could you fix it?

expected: "{\"error\":\"Bad Request: shortcode  did not pass validation, must be between 2 and 30 characters, lowercase letters, numbers, and underscores only\"}"
actual  : "{\"error\":\"Bad Request: shortcode  did not pass validation, must be between 2 and 30 characters, letters, numbers, and underscores only\"}"

@tsmethurst
Copy link
Contributor

Thanks!

@tsmethurst tsmethurst merged commit 1f39275 into superseriousbusiness:main Jun 2, 2023
2 checks passed
tsmethurst pushed a commit that referenced this pull request Jun 14, 2023
* Replace pinafore with semaphore

* Typo

* Allow lowercase emoji shortcode in frontend

* Fix failing test (corrected expected outcome)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Backend does not enforce lowercase shortcode for emoji, frontend does
2 participants