Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐸Restructure Frontend Sources #634

Merged
merged 35 commits into from Jun 9, 2022
Merged

🐸Restructure Frontend Sources #634

merged 35 commits into from Jun 9, 2022

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Jun 6, 2022

Include admin and future user panel in main repo, properly deduplicate bundles for css+js across uses

Mostly ready, but needs more testing to prevent regressions, and some documentation updates

@f0x52
🐸restructure frontend stuff, include admin and future user panel in m…
f971763 
…ain repo, properly deduplicate bundles for css+js across uses
@f0x52 f0x52 added the frontend Frontend-related stuff label Jun 6, 2022
@f0x52 f0x52 self-assigned this Jun 6, 2022
@f0x52
Copy link
Contributor Author

f0x52 commented Jun 7, 2022 •
edited

  • documentation
  • check release flow
  • update dev server to work better in tandem with testrig

@f0x52 f0x52 mentioned this pull request Jun 7, 2022
Closed
f0x52
f0x52 commented Jun 8, 2022
View reviewed changes
.goreleaser.yml Outdated Show resolved Hide resolved
f0x52
f0x52 commented Jun 8, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
f0x52
f0x52 commented Jun 8, 2022
View reviewed changes
internal/web/base.go
@@ -136,16 +136,74 @@ func (m *Module) NotFoundHandler(c *gin.Context) {
})
}

// TODO: abstract the {admin, user}panel handlers in some way
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good way to abstract this? maybe save it for a later PR

martijndeb
martijndeb reviewed Jun 8, 2022
View reviewed changes
web/template/header.tmpl Outdated Show resolved Hide resolved
tsmethurst
tsmethurst reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far :) Since the javascript files from the admin panel etc are now in the main repo, you should probably add the license text that's in the go files to the top of the javascript files as well.

@f0x52
Copy link
Contributor Author

f0x52 commented Jun 8, 2022

sprinkles some license headers

tsmethurst
tsmethurst reviewed Jun 8, 2022
View reviewed changes
internal/web/base.go Outdated Show resolved Hide resolved
@f0x52 f0x52 mentioned this pull request Jun 9, 2022
Merged
@tsmethurst tsmethurst marked this pull request as ready for review June 9, 2022 10:48
@tsmethurst tsmethurst merged commit b43f9ce into main Jun 9, 2022
@tsmethurst tsmethurst deleted the frogend-restructure branch June 9, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijndeb martijndeb martijndeb left review comments

@tsmethurst tsmethurst tsmethurst left review comments

Assignees

@f0x52 f0x52

Labels
frontend Frontend-related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f0x52 @martijndeb @tsmethurst