Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Procfile compatible with herokuish #12685

Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 23, 2019

@@ -0,0 +1,2 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

and you are missing a new line.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we added a set -e below this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -eou pipefail if not commands should fail in the script at all.

@stale
Copy link

stale bot commented Apr 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added status/wontfix This will not be worked on and removed status/wontfix This will not be worked on labels Apr 30, 2020
@SuperSandro2000
Copy link
Contributor

bump

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Aug 29, 2020
@stale stale bot removed the status/wontfix This will not be worked on label Aug 29, 2020
@Gargron Gargron merged commit 8630afb into mastodon:master Aug 29, 2020
@ghost ghost deleted the bugfix/herokuish-compat branch August 30, 2020 10:57
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 6, 2020
Co-authored-by: Aurelia <aurelia@serenitylabs.cloud>
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
Co-authored-by: Aurelia <aurelia@serenitylabs.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants