Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS IDE helper #13012

Merged
merged 3 commits into from Apr 27, 2020
Merged

Add JS IDE helper #13012

merged 3 commits into from Apr 27, 2020

Conversation

Grawl
Copy link
Contributor

@Grawl Grawl commented Jan 31, 2020

In JetBrains IDE, like WebStorm or RubyMine, this import is not recognized as valid import:

import Icon from 'mastodon/components/icon';

IDE has Webpack support but I don't know a way to set it up with complex Webpack configurations such as one used in this repository.

To let IDE know where is 'mastodon' alias is located, there is a trick: write fake Webpack config just for IDE, provide used aliases in form IDE understand, and select this file as Webpack config in IDE settings.

ide-helper.js Show resolved Hide resolved
@Grawl
Copy link
Contributor Author

Grawl commented Feb 12, 2020

oh there is a new linter errors

@Grawl
Copy link
Contributor Author

Grawl commented Feb 12, 2020

Your bundle is locked to httplog (1.4.0), but that version could not be found in
any of the sources listed in your Gemfile

I have the same error when I trying build Mastodon in Docker locally on Fedora 31

@brawaru
Copy link
Contributor

brawaru commented Feb 12, 2020

Try rebasing onto upstream/master? During rebase you can also squash your commits.

@Grawl
Copy link
Contributor Author

Grawl commented Feb 12, 2020

Can you squash on merge? I prefer to not squash on local.

@brawaru
Copy link
Contributor

brawaru commented Feb 12, 2020

Mastodon maintainers always squash commits on merge. Squashing manually just allows to preserve sane commit message, automatic one can be misleading at times, but that's entirely one's choice.

Rebase worked, dependencies are installed and testing has just started.

@Gargron Gargron changed the title add JS IDE helper Add JS IDE helper Apr 27, 2020
@Gargron Gargron merged commit ee017ca into mastodon:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants