Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RAILS_ENV in Procfile.dev #15502

Merged
merged 2 commits into from Jan 7, 2021
Merged

Set RAILS_ENV in Procfile.dev #15502

merged 2 commits into from Jan 7, 2021

Conversation

abcang
Copy link
Contributor

@abcang abcang commented Jan 6, 2021

Procfile.dev is a development file, and it is convenient if RAILS_ENV=development is set.

@@ -1,4 +1,4 @@
web: env PORT=3000 bundle exec puma -C config/puma.rb
web: env PORT=3000 RAILS_ENV=development bundle exec puma -C config/puma.rb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not also needed for sidekiq below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of sidekiq, the error did not occur even if it was not explicitly set.
Apparently RAILS_ENV is set to development by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also set it to sidekiq to avoid confusion.

@Gargron Gargron merged commit 7cb7295 into mastodon:master Jan 7, 2021
@abcang abcang deleted the fix_procfile branch January 7, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants