Autofix Rubocop remaining Layout rules #23679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
nschonni
force-pushed
the
remaining-layout-cops
branch
from
35f42da
to
a78f1fd
Compare
nschonni
force-pushed
the
remaining-layout-cops
branch
2 times, most recently
from
e6257e9
to
be79902
Compare
|
@Gargron this is one of the bigger cleanups, but I could break it up if it's easier to review |
|
I do not like when hash arguments are indented so much. In my opinion they should be only 2 spaces in compared to first line. |
nschonni
force-pushed
the
remaining-layout-cops
branch
from
be79902
to
65c995d
Compare
Gargron
approved these changes
Feb 20, 2023
|
OK, rebased out the changes to |
Lamparter
referenced
this pull request
in RiversideValley/Plaza
Feb 21, 2023
* Autofix Rubocop Style/EmptyMethod (#23732) * Autofix Rubocop Rails/RedundantForeignKey (#23731) * Autofix Rubocop Rails/Pluck (#23730) * Autofix Rubocop RSpec/ReturnFromStub (#23724) * Enable Rubocop RSpec/NotToNot (#23723) * Autofix Rubocop Lint/UnusedBlockArgument (#23712) * Autofix Rubocop RSpec/EmptyLineAfterSubject (#23719) * Enable Rubocop HTTP status rules (#23717) * Autofix Rubocops RSpec/ScatteredLet (#23725) * Autofix Rubocop Style/ExplicitBlockArgument (#23704) * Rename JSX files with proper `.jsx` extension (#23733) * Autofix Rubocop Rails/EnumHash (#23737) * Autofix Rubocop RSpec/ImplicitSubject (#23721) * Enable Rubocop RSpec/ExpectActual (#23720) * Autofix Rubocop RSpec/LeadingSubject (#23670) * Audofix Rubocop Style/WordArray (#23739) * Autofix Rubocop RSpec/BeEq (#23740) * Autofix Rubocop Style/UnpackFirst (#23741) * Autofix Rubocop remaining Layout rules (#23679) * Fix Markdown files with Prettier and check in CI (#21972) * Autofix Rubocop Style/FormatString (#23743) * Autofix Rubocop Style/SymbolProc (#23742) * Make larger part of status clickable (#23621) * Delete CHANGELOG.md * Delete CONTRIBUTING.md * Delete compose_form.jsx * Create compose_form.jsx --------- Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Renaud Chaput <renchap@gmail.com> Co-authored-by: Christian Schmidt <github@chsc.dk>
Lamparter
referenced
this pull request
in RiversideValley/Plaza
Feb 21, 2023
* Autofix Rubocop Style/EmptyMethod (#23732) * Autofix Rubocop Rails/RedundantForeignKey (#23731) * Autofix Rubocop Rails/Pluck (#23730) * Autofix Rubocop RSpec/ReturnFromStub (#23724) * Enable Rubocop RSpec/NotToNot (#23723) * Autofix Rubocop Lint/UnusedBlockArgument (#23712) * Autofix Rubocop RSpec/EmptyLineAfterSubject (#23719) * Enable Rubocop HTTP status rules (#23717) * Autofix Rubocops RSpec/ScatteredLet (#23725) * Autofix Rubocop Style/ExplicitBlockArgument (#23704) * Rename JSX files with proper `.jsx` extension (#23733) * Autofix Rubocop Rails/EnumHash (#23737) * Autofix Rubocop RSpec/ImplicitSubject (#23721) * Enable Rubocop RSpec/ExpectActual (#23720) * Autofix Rubocop RSpec/LeadingSubject (#23670) * Audofix Rubocop Style/WordArray (#23739) * Autofix Rubocop RSpec/BeEq (#23740) * Autofix Rubocop Style/UnpackFirst (#23741) * Autofix Rubocop remaining Layout rules (#23679) * Fix Markdown files with Prettier and check in CI (#21972) * Autofix Rubocop Style/FormatString (#23743) * Autofix Rubocop Style/SymbolProc (#23742) * Make larger part of status clickable (#23621) * Autofix Rubocop Style/RescueStandardError (#23745) * Update rebase needed job settings (#23746) * Change compose form checkbox to native input with `appearance: none` (#22949) * Autofix Rubocop Rails/WhereEquals (#23759) * Autofix Rubocop Security/IoMethods (#23757) * Autofix Rubocop Rails/FindById (#23762) * Add `lang` tag to native language names in language picker (#23749) * Bump capistrano from 3.17.1 to 3.17.2 (#23775) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump sass from 1.58.2 to 1.58.3 (#23772) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump blurhash from 2.0.4 to 2.0.5 (#23771) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump stylelint from 15.1.0 to 15.2.0 (#23770) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix sidebar cut-off on small screens in admin UI (#23764) * Bump devise from 4.8.1 to 4.9.0 (#23691) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/runtime from 7.20.13 to 7.21.0 (#23773) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/core from 7.20.12 to 7.21.0 (#23767) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/plugin-transform-runtime from 7.19.6 to 7.21.0 (#23774) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/plugin-transform-react-inline-elements from 7.18.6 to 7.21.0 (#23766) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/plugin-proposal-decorators from 7.20.13 to 7.21.0 (#23769) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Delete CHANGELOG.md * Delete CONTRIBUTING.md --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Renaud Chaput <renchap@gmail.com> Co-authored-by: Christian Schmidt <github@chsc.dk> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Botao Wang <wxt2005@gmail.com>
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autofix the remaining Layout Rubocop rules, except for LineLenght. I thin the LineLength is probably best left to the very end as it will likely create the most noise