Fix more haml-lint Rubocop

[nschonni]

Took a pass by deleting the section from the todo and re-running the lint to see what it was suppressing. There currently isn't any autofix for these rubocops so probably needs an extra check to see I didn't mess anything up doing manual edits

The remaining issues when commenting out the section again

app/views/accounts/_og.html.haml:13 [W] RuboCop: Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
app/views/admin/account_warnings/_account_warning.html.haml:8 [W] RuboCop: Rails/OutputSafety: Tagging a string as html safe may be a security risk.
app/views/admin/accounts/index.html.haml:50 [W] RuboCop: Style/SymbolProc: Pass `&:user_pending?` as an argument to `any?` instead of a block.
app/views/admin/accounts/show.html.haml:75 [W] RuboCop: Rails/WhereExists: Prefer `exists?(reference_account_id: @account.id)` over `where(reference_account_id: @account.id).exists?`.
app/views/admin/accounts/show.html.haml:138 [W] RuboCop: Style/SoleNestedConditional: Consider merging nested conditions into outer `if` conditions.
app/views/admin/accounts/show.html.haml:207 [W] RuboCop: Style/SoleNestedConditional: Consider merging nested conditions into outer `if` conditions.
app/views/admin/accounts/show.html.haml:217 [W] RuboCop: Style/IfInsideElse: Convert `if` nested inside `else` to `elsif`.
app/views/admin/accounts/show.html.haml:235 [W] RuboCop: Style/SoleNestedConditional: Consider merging nested conditions into outer `unless` conditions.
app/views/admin/accounts/show.html.haml:238 [W] RuboCop: Style/SoleNestedConditional: Consider merging nested conditions into outer `if` conditions.
app/views/admin/accounts/show.html.haml:243 [W] RuboCop: Style/SoleNestedConditional: Consider merging nested conditions into outer `if` conditions.
app/views/admin/accounts/show.html.haml:245 [W] RuboCop: Style/IfInsideElse: Convert `if` nested inside `else` to `elsif`.
app/views/admin/announcements/edit.html.haml:11 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/announcements/edit.html.haml:12 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/announcements/edit.html.haml:22 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/announcements/new.html.haml:11 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/announcements/new.html.haml:12 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/announcements/new.html.haml:21 [W] RuboCop: Rails/TimeZone: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.xmlschema`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.httpdate`, `Time.now.to_i`, `Time.now.to_f` instead. (https://rails.rubystyle.guide#time, http://danilenko.org/2012/7/6/rails_timezones)
app/views/admin/disputes/appeals/_appeal.html.haml:7 [W] RuboCop: Rails/OutputSafety: Tagging a string as html safe may be a security risk.
app/views/admin/domain_blocks/edit.html.haml:15 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/domain_blocks/new.html.haml:15 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/ip_blocks/new.html.haml:11 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/ip_blocks/new.html.haml:14 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/reports/actions/preview.html.haml:35 [W] RuboCop: Style/NegatedIf: Favor `unless` over `if` for negative conditions. (https://rubystyle.guide#unless-for-negatives)
app/views/admin/reports/actions/preview.html.haml:64 [W] RuboCop: Rails/LinkToBlank: Specify a `:rel` option containing noopener. (https://mathiasbynens.github.io/rel-noopener/, https://html.spec.whatwg.org/multipage/links.html#link-type-noopener, https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer)
app/views/admin/reports/index.html.haml:30 [W] RuboCop: Lint/UnusedBlockArgument: Unused block argument - `target_account_id`. If it's necessary, use `_` or `_target_account_id` as an argument name to indicate that it won't be used. (https://rubystyle.guide#underscore-unused-vars)
app/views/admin/reports/show.html.haml:95 [W] RuboCop: Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
app/views/admin/roles/_form.html.haml:35 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/roles/_form.html.haml:35 [W] RuboCop: Style/NumericPredicate: Use `(UserRole::FLAGS[privilege] & current_user.role.computed_permissions).zero?` instead of `UserRole::FLAGS[privilege] & current_user.role.computed_permissions == 0`. (https://rubystyle.guide#predicate-methods)
app/views/admin/settings/about/show.html.haml:25 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/settings/about/show.html.haml:27 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/settings/appearance/show.html.haml:17 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/settings/registrations/show.html.haml:18 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/admin/statuses/show.html.haml:8 [W] RuboCop: Rails/LinkToBlank: Specify a `:rel` option containing noopener. (https://mathiasbynens.github.io/rel-noopener/, https://html.spec.whatwg.org/multipage/links.html#link-type-noopener, https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer)
app/views/auth/registrations/new.html.haml:28 [W] RuboCop: Rails/Blank: Use `@invite.blank?` instead of `!@invite.present?`.
app/views/disputes/strikes/show.html.haml:28 [W] RuboCop: Rails/Present: Use `if @strike.text.present?` instead of `unless @strike.text.blank?`.
app/views/disputes/strikes/show.html.haml:60 [W] RuboCop: Rails/LinkToBlank: Specify a `:rel` option containing noopener. (https://mathiasbynens.github.io/rel-noopener/, https://html.spec.whatwg.org/multipage/links.html#link-type-noopener, https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer)
app/views/filters/_filter_fields.html.haml:5 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/filters/_filter_fields.html.haml:8 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/invites/_form.html.haml:6 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/invites/_form.html.haml:8 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/layouts/application.html.haml:27 [W] RuboCop: Rails/OutputSafety: Tagging a string as html safe may be a security risk.
app/views/layouts/error.html.haml:4 [W] RuboCop: Style/HashSyntax: Don't mix styles in the same hash. (https://rubystyle.guide#hash-literals)
app/views/notification_mailer/_status.html.haml:36 [W] RuboCop: Style/NumericPredicate: Use `status.ordered_media_attachments.size.positive?` instead of `status.ordered_media_attachments.size > 0`. (https://rubystyle.guide#predicate-methods)
app/views/notification_mailer/_status.html.haml:36 [W] RuboCop: Style/ZeroLengthPredicate: Use `!empty?` instead of `size > 0`.
app/views/settings/applications/_fields.html.haml:10 [W] RuboCop: Rails/OutputSafety: Tagging a string as html safe may be a security risk.
app/views/settings/applications/_fields.html.haml:17 [W] RuboCop: Lint/UnusedBlockArgument: Unused block argument - `k`. If it's necessary, use `_` or `_k` as an argument name to indicate that it won't be used. (https://rubystyle.guide#underscore-unused-vars)
app/views/settings/applications/_fields.html.haml:18 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/imports/show.html.haml:6 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/imports/show.html.haml:12 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/appearance/show.html.haml:10 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/appearance/show.html.haml:12 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/appearance/show.html.haml:56 [W] RuboCop: Style/WordArray: Use `%w` or `%W` for an array of words. (https://rubystyle.guide#percent-w)
app/views/settings/preferences/appearance/show.html.haml:56 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/other/show.html.haml:20 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/other/show.html.haml:23 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/settings/preferences/other/show.html.haml:34 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/statuses/_detailed_status.html.haml:80 [W] RuboCop: Rails/LinkToBlank: Specify a `:rel` option containing noopener. (https://mathiasbynens.github.io/rel-noopener/, https://html.spec.whatwg.org/multipage/links.html#link-type-noopener, https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer)
app/views/statuses/_poll.html.haml:10 [W] RuboCop: Style/NumericPredicate: Use `total_votes_count.positive?` instead of `total_votes_count > 0`. (https://rubystyle.guide#predicate-methods)
app/views/statuses/_poll.html.haml:20 [W] RuboCop: Style/MinMaxComparison: Use `[percent, 1].max` instead.
app/views/statuses/show.html.haml:16 [W] RuboCop: Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
app/views/statuses_cleanup/show.html.haml:13 [W] RuboCop: Style/Lambda: Use the `-> { ... }` lambda literal syntax for single line lambdas. (https://rubystyle.guide#lambda-multi-line)
app/views/user_mailer/warning.html.haml:42 [W] RuboCop: Rails/Present: Use `if @warning.text.present?` instead of `unless @warning.text.blank?`.
app/views/user_mailer/warning.html.haml:71 [W] RuboCop: Rails/Blank: Use `@statuses.blank?` instead of `@statuses.nil? || @statuses.empty?`.

218 files inspected, 63 lints detected

[nschonni]

Was less sure about this one