fix: remove port 80 mapping in devcontainer #24658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change leaves ports 3000 and 4000 mapped, but removes port 80. On MacOS and possible other OSes, mapping port 80 requires a preference change on docker as it's a privileged port. The devcontainer fails to run without this change, which is a annoying. Additionally, this mapping will fail for anyone that already has port 80 mapped for some other purpose.
|
Ping @rrgeorge and @samruddhikhandale because of PR #24303 |
|
I am using the devcontainer on my Mac |
ykzts
approved these changes
Apr 30, 2023
michealmikeyb
pushed a commit
to michealmikeyb/mastodon
that referenced
this pull request
May 3, 2023
minacle
referenced
this pull request
in uri-life/mastodon
May 25, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change leaves ports 3000 and 4000 mapped, but removes port 80.
On MacOS and possible other OSes, mapping port 80 requires a preference
change on docker as it's a privileged port. The devcontainer fails to
run without this change, which is a annoying. Additionally, this mapping
will fail for anyone that already has port 80 mapped for some other
purpose.