mirror of https://github.com/rust-lang/rust
0a917f89f3
Add `ErrorGuaranteed` to `Recovered::Yes` and use it more.
The starting point for this was identical comments on two different fields, in `ast::VariantData::Struct` and `hir::VariantData::Struct`:
```
// FIXME: investigate making this a `Option<ErrorGuaranteed>`
recovered: bool
```
I tried that, and then found that I needed to add an `ErrorGuaranteed` to `Recovered::Yes`. Then I ended up using `Recovered` instead of `Option<ErrorGuaranteed>` for these two places and elsewhere, which required moving `ErrorGuaranteed` from `rustc_parse` to `rustc_ast`.
This makes things more consistent, because `Recovered` is used in more places, and there are fewer uses of `bool` and
`Option<ErrorGuaranteed>`. And safer, because it's difficult/impossible to set `recovered` to `Recovered::Yes` without having emitted an error.
r? `@oli-obk`
|
||
|---|---|---|
| .. | ||
| assert | ||
| deriving | ||
| format_foreign | ||
| alloc_error_handler.rs | ||
| asm.rs | ||
| assert.rs | ||
| cfg.rs | ||
| cfg_accessible.rs | ||
| cfg_eval.rs | ||
| cmdline_attrs.rs | ||
| compile_error.rs | ||
| concat.rs | ||
| concat_bytes.rs | ||
| concat_idents.rs | ||
| derive.rs | ||
| edition_panic.rs | ||
| env.rs | ||
| errors.rs | ||
| format.rs | ||
| format_foreign.rs | ||
| global_allocator.rs | ||
| lib.rs | ||
| log_syntax.rs | ||
| pattern_type.rs | ||
| proc_macro_harness.rs | ||
| source_util.rs | ||
| standard_library_imports.rs | ||
| test.rs | ||
| test_harness.rs | ||
| trace_macros.rs | ||
| util.rs | ||