mirror of https://github.com/rust-lang/rust
5568c569c0
This commit fixes several issues with the format string parsing of the
`#[diagnostic::on_unimplemented]` attribute that were pointed out by
@ehuss.
In detail it fixes:
* Appearing format specifiers (display, etc). For these we generate a
warning that the specifier is unsupported. Otherwise we ignore them
* Positional arguments. For these we generate a warning that positional
arguments are unsupported in that location and replace them with the
format string equivalent (so `{}` or `{n}` where n is the index of the
positional argument)
* Broken format strings with enclosed }. For these we generate a warning
about the broken format string and set the emitted message literally to
the provided unformatted string
* Unknown format specifiers. For these we generate an additional warning
about the unknown specifier. Otherwise we emit the literal string as
message.
This essentially makes those strings behave like `format!` with the
minor difference that we do not generate hard errors but only warnings.
After that we continue trying to do something unsuprising (mostly either
ignoring the broken parts or falling back to just giving back the
literal string as provided).
Fix #122391
|
||
|---|---|---|
| .. | ||
| auxiliary | ||
| broken_format.rs | ||
| broken_format.stderr | ||
| do_not_accept_options_of_the_internal_rustc_attribute.rs | ||
| do_not_accept_options_of_the_internal_rustc_attribute.stderr | ||
| do_not_fail_parsing_on_invalid_options_1.rs | ||
| do_not_fail_parsing_on_invalid_options_1.stderr | ||
| error_is_shown_in_downstream_crates.rs | ||
| error_is_shown_in_downstream_crates.stderr | ||
| ignore_unsupported_options_and_continue_to_use_fallback.rs | ||
| ignore_unsupported_options_and_continue_to_use_fallback.stderr | ||
| multiple_notes.rs | ||
| multiple_notes.stderr | ||
| on_unimplemented_simple.rs | ||
| on_unimplemented_simple.stderr | ||
| report_warning_on_duplicated_options.rs | ||
| report_warning_on_duplicated_options.stderr | ||