Open issue indicator is blue #2

Closed
opened 2022-05-24 08:58:43 -06:00 by crystal · 5 comments

image

This looks really out of place. This indicator should be either green (to indicate an open issue like GitHub) or violet (to match the accents of the theme)

![image](/attachments/da74d6ce-b39f-4eb0-a768-7731cd879cd9) This looks really out of place. This indicator should be either green (to indicate an open issue like GitHub) or violet (to match the accents of the theme)
5.8 KiB
Poster
Owner

Related; this blue color also appears on the counters for the issue overview screen, which looks especially bad on top of the dark purple as seen here.
image

Related; this blue color also appears on the counters for the issue overview screen, which looks especially bad on top of the dark purple as seen here. ![image](/attachments/66364a8e-2fa8-448e-8a52-b8e029b3bdd1)
4.5 KiB
Poster
Owner

The same color is probably used for open pull requests. If the open issue indicator is changed to purple, this will cause a bit of a conflict with the merged indicator.
image
This merged indicator also looks slightly out of place since it's a lot hotter than the violets used in the rest of the theme.

The same color is probably used for open pull requests. If the open issue indicator is changed to purple, this will cause a bit of a conflict with the merged indicator. ![image](/attachments/0ac755ed-a4b5-46b2-a6a0-7227c5fd3846) This merged indicator also looks slightly out of place since it's a lot hotter than the violets used in the rest of the theme.
4.7 KiB
Poster
Owner

Related; this blue color also appears on the counters for the issue overview screen, which looks especially bad on top of the dark purple as seen here.

image

The red color used for closed issues also looks a little out of place in this context. That being said, I don't really want to change the indicator color for closed issues.
image

> Related; this blue color also appears on the counters for the issue overview screen, which looks especially bad on top of the dark purple as seen here. > \[image\] The red color used for closed issues also looks a little out of place in this context. That being said, I don't really want to change the indicator color for closed issues. ![image](/attachments/5e4fac4e-11ae-4ca2-89b7-51d9f579a6ab)
1.3 KiB
Poster
Owner

Also related; the smaller indicator in the issue list screen is still green, even though the badge on the issue page is blue. The inconsistency here is not ideal.
image

Also related; the smaller indicator in the issue list screen is still green, even though the badge on the issue page is blue. The inconsistency here is not ideal. ![image](/attachments/60f88ce3-b326-4e4c-bd80-a3e8622e42a0)
6.9 KiB
crystal added the
bug
dark
labels 2022-05-24 09:34:40 -06:00
Poster
Owner

gonna fix this by just removing the section that colors this object. I don't know if it's used elsewhere in the inferface, if it is and that looks bad I'll hopefully notice it and open a new bug.

gonna fix this by just removing the section that colors this object. I don't know if it's used elsewhere in the inferface, if it is and that looks bad I'll hopefully notice it and open a new bug.
crystal referenced this issue from a commit 2022-05-27 06:04:43 -06:00
crystal added this to the Delightful milestone 2022-06-08 14:20:53 -06:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: crystal/committed-violet#2
There is no content yet.