forked from mirror/earl-grey
Heatmap is mostly blue #1
Labels
No Label
bug
dark
enhancement
light
needs testing
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: crystal/committed-violet#1
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
I have not yet taken the time to adjust the colors for the heatmap, however one of the color variables I have already adjusted is used in one of the middle heatmap levels, making it an unusually dark purple color. This will probably take me a while to get completely ironed out and tested properly.
This has also been confirmed to also occur in the light variant (#5) (which stands to reason since it uses most of the same pallete adjustments)
Dark theme is looking good (sorry this screenshot isn't ideal as I don't have a rich commit history for the last year)
These two commits contain a passable solution for the dark and light themes respectively.
a7039460b2
e657024e7a
I think the dark background makes the subtle differences between the shades stand out more. They blend together a bit more against the white background, but I'm gonna call this good enough to close this issue. I'll keep playing with it and maybe open an enhancement issue if I decide it needs to be changed.